[ https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616748#comment-17616748 ]
ASF GitHub Bot commented on HADOOP-18360: ----------------------------------------- hadoop-yetus commented on PR #4928: URL: https://github.com/apache/hadoop/pull/4928#issuecomment-1276932902 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 53s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +0 :ok: | xmllint | 0m 1s | | xmllint was not available. | | +0 :ok: | shelldocs | 0m 1s | | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 15m 19s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 32m 30s | | trunk passed | | +1 :green_heart: | compile | 31m 46s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | compile | 22m 11s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 4m 25s | | trunk passed | | +1 :green_heart: | mvnsite | 20m 31s | | trunk passed | | +1 :green_heart: | javadoc | 8m 29s | | trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 7m 32s | | trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +0 :ok: | spotbugs | 0m 24s | | branch/hadoop-project no spotbugs output file (spotbugsXml.xml) | | +1 :green_heart: | shadedclient | 58m 31s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 25m 49s | | the patch passed | | +1 :green_heart: | compile | 25m 0s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javac | 25m 0s | | the patch passed | | +1 :green_heart: | compile | 22m 1s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 22m 1s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 4m 15s | | the patch passed | | +1 :green_heart: | mvnsite | 20m 53s | | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | | No new issues. | | +1 :green_heart: | javadoc | 8m 53s | | the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 | | +1 :green_heart: | javadoc | 8m 0s | | the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | +0 :ok: | spotbugs | 0m 23s | | hadoop-project has no data from spotbugs | | +1 :green_heart: | shadedclient | 59m 5s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | -1 :x: | unit | 1021m 25s | [/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/artifact/out/patch-unit-root.txt) | root in the patch passed. | | +1 :green_heart: | asflicense | 2m 2s | | The patch does not generate ASF License warnings. | | | | 1408m 7s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4928 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs | | uname | Linux 4fe0f10ef2db 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / bb866f1daba1e8af40316d7bb7101eb5712ccaba | | Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/testReport/ | | Max. process+thread count | 3439 (vs. ulimit of 5500) | | modules | C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice . U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4928/5/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > Update commons-csv from 1.0 to 1.9.0. > ------------------------------------- > > Key: HADOOP-18360 > URL: https://issues.apache.org/jira/browse/HADOOP-18360 > Project: Hadoop Common > Issue Type: Improvement > Components: common > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Labels: pull-request-available > > commons-csv 1.0 is a very old jar, mvnrepository shows this jar as the 2014 > version, I have compiled and tested locally, I think this jar can be upgraded > to commons-csv 1.9 version. > The link to the release note is as follows: > [https://commons.apache.org/proper/commons-csv/changes-report.html] > We can see that the new version fixes some issues. > I read the code used, we use header related methods. We found that many > header-related methods have been upgraded. > *Release 1.1 – 2014-11-16* > CSVFormat#withHeader doesn't work well with #printComment, add > withHeaderComments(String...). > CSVFormat.EXCEL should ignore empty header names. > *Release 1.2 – 2015-08-24* > CSVFormat.with* methods clear the header comments. > *Release 1.3 – 2016-05-09* > Add shortcut method for using first record as header to CSVFormat. > Add withHeader(Class<? extends Enum>) to CSVFormat. > CSVPrinter doesn't skip creation of header record if skipHeaderRecord is set > to true. > Add IgnoreCase option for accessing header names. > *Release 1.5 – 2017-09-03* > Fix incorrect method name 'withFirstRowAsHeader' in user guide. > *Release 1.7 – 2019-06-01* > Cannot get headers in column order from CSVRecord. > *Release 1.8 – 2020-02-01* > CSVFormat#validate() does not account for allowDuplicateHeaderNames. > A single empty header is allowed when not allowing empty column headers. > *Release 1.9.0 – 2020-07-24* > Add possibility to use ResultSet header meta data as CSV header. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org