Hexiaoqiao commented on PR #5041: URL: https://github.com/apache/hadoop/pull/5041#issuecomment-1283409872
@steveloughran Thanks for push this PR forward. > trunk commit doesn't state what version was upgraded too Agree, we should state version when upgrade dependencies. + I think it is good practice to modify PR and issue title also to keep it same as commit message. > needs a newline between title and body to stop various tools joining them Sorry I did not get this information. IIUC, you mentioned here is 'Contributed by ***.', right? If that, this format has kept for a long long while although it did not state clearly at 'HowToCommit' guide[1]. I have no idea if we should norm it. For me both of them are good. Thanks. [1] https://cwiki.apache.org/confluence/display/HADOOP2/HowToCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
