[ 
https://issues.apache.org/jira/browse/HADOOP-18011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623444#comment-17623444
 ] 

ASF GitHub Bot commented on HADOOP-18011:
-----------------------------------------

mukund-thakur commented on code in PR #3662:
URL: https://github.com/apache/hadoop/pull/3662#discussion_r1003823510


##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemE2E.java:
##########
@@ -229,4 +238,43 @@ private void testWriteOneByteToFile(Path testFilePath) 
throws Exception {
     FileStatus fileStatus = fs.getFileStatus(testFilePath);
     assertEquals(1, fileStatus.getLen());
   }
+
+  @Test
+  public void testHttpConnectionTimeout() throws Exception {
+    // Not seeing connection failures while testing with 1 ms connection
+    // timeout itself and on repeated TPCDS runs when cluster
+    // and account are in same region, 10 ms is seen stable.
+    // 500 ms is seen stable for cross region.
+    testHttpTimeouts(TEST_STABLE_DEFAULT_CONNECTION_TIMEOUT_MS,
+        TEST_STABLE_DEFAULT_READ_TIMEOUT_MS);
+  }
+
+  @Test(expected = InvalidAbfsRestOperationException.class)
+  public void testHttpReadTimeout() throws Exception {
+    // Small read timeout is bound to make the request fail.
+    testHttpTimeouts(TEST_STABLE_DEFAULT_CONNECTION_TIMEOUT_MS,

Review Comment:
   We can use intercept here 
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/LambdaTestUtils.java#L380
   





> ABFS: Enable config control for default connection timeout 
> -----------------------------------------------------------
>
>                 Key: HADOOP-18011
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18011
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.3.1
>            Reporter: Sneha Vijayarajan
>            Assignee: Sneha Vijayarajan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> ABFS driver has a default connection timeout and read timeout value of 30 
> secs. For jobs that are time sensitive, preference would be quick failure and 
> have shorter HTTP connection and read timeout. 
> This Jira is created enable config control over the default connection and 
> read timeout. 
> New config name:
> fs.azure.http.connection.timeout
> fs.azure.http.read.timeout



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to