[GitHub] [hadoop] simbadzina commented on a diff in pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

[GitBox]

simbadzina commented on code in PR #5088:
URL: https://github.com/apache/hadoop/pull/5088#discussion_r1015741184


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2879,9 +2880,12 @@ private void processRpcRequest(RpcRequestHeaderProto 
header,
             stateId = alignmentContext.receiveRequestState(
                 header, getMaxIdleTime());
             call.setClientStateId(stateId);
-            if (header.hasRouterFederatedState()) {
-              
call.setFederatedNamespaceState(header.getRouterFederatedState());
-            }
+          }
+          if (header.hasRouterFederatedState()) {
+            call.setFederatedNamespaceState(header.getRouterFederatedState());
+          } else if (header.hasStateId()) {
+            // Set one empty FederatedNamespaceState to identify the client 
want to get stateId.
+            call.setFederatedNamespaceState(EMPTY_BYTE_STRING);

Review Comment:
   Typo "wants" instead of "want"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org