[
https://issues.apache.org/jira/browse/HADOOP-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634252#comment-17634252
]
ASF GitHub Bot commented on HADOOP-18498:
-----------------------------------------
sreeb-msft opened a new pull request, #5136:
URL: https://github.com/apache/hadoop/pull/5136
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
This PR parses SAS Tokens and removes the unwanted prefix of '?' from them,
if present.
At present, SAS Tokens generated from the Azure Portal may or may not
contain a '?' as a prefix. SAS Tokens that contain the '?' prefix will lead to
an error in the driver due to a clash of query parameters. This leads to
customers having to manually remove the '?' prefix before passing the SAS
Tokens.
After receiving the SAS Token from the provider (customer implementation of
the SASTokenProvider interface in the driver code), The code checks for whether
any ? prefix is present or not. If yes, it is removed before further usage of
the token. This way, users would not have to manually remove the prefix before
passing it on as a configuration.
#### Test Code added:
An additional test case has been added to the existing integration test
class for SAS (ITestAzureBlobFileSystemDelegationSAS) - testSASQuesMarkPrefix.
This method sets the SAS Token Provider to forcefully send a SAS Token with a ?
mark prefix and then tests filesystem creation with this.
> [ABFS]: Error introduced when SAS Token containing '?' prefix is passed
> -----------------------------------------------------------------------
>
> Key: HADOOP-18498
> URL: https://issues.apache.org/jira/browse/HADOOP-18498
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Reporter: Sree Bhattacharyya
> Assignee: Sree Bhattacharyya
> Priority: Minor
>
> Error Description:
> At present, SAS Tokens generated from the Azure Portal may or may not contain
> a ? as a prefix. SAS Tokens that contain the ? prefix will lead to an error
> in the driver due to a clash of query parameters. This leads to customers
> having to manually remove the ? prefix before passing the SAS Tokens.
> Mitigation:
> After receiving the SAS Token from the provider, check if any prefix ? is
> present or not. If present, remove it and pass the SAS Token.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
