steveloughran commented on code in PR #5136: URL: https://github.com/apache/hadoop/pull/5136#discussion_r1022841613
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ########## @@ -1130,6 +1130,10 @@ private String appendSASTokenToQuery(String path, sasToken = cachedSasToken; LOG.trace("Using cached SAS token."); } + // if SAS Token contains a prefix of ?, it should be removed + if(sasToken.charAt(0) == '?') { + sasToken = sasToken.substring(1); Review Comment: what if the token length==1? it's clearly invalid, but what error gets raised? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org