simbadzina commented on PR #5123:
URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1319412848
> > Code looks good to me. Do you know why there are these new Spotbugs
violations?
>
> Because of this change, and we did not config configure filter.
`hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto →
hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/FederationProtocol.proto `
>
> One small question. If we migrate `FederationProtocol.proto` directly to
the `hadoop-hdfs-client` directory, do you think this is reasonable? @ZanderXu
@goiri @simbadzina
@tomscut Moving the whole FederationProtocol in the hadoop-hdfs-client feels
a bit off since most of it is mostly server side stuff.
What do you think about moving just
> message RouterFederatedStateProto {
map<string, int64> namespaceStateIds = 1; // Last seen state IDs for
multiple namespaces.
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
