tasanuma commented on code in PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#discussion_r1025976920
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##########
@@ -432,8 +432,16 @@ private class VerifyECCommand extends DebugCommand {
VerifyECCommand() {
super("verifyEC",
- "verifyEC -file <file>",
- " Verify HDFS erasure coding on all block groups of the file.");
+ "verifyEC -file <file> [-blockId <blk_Id>] [-ignoreFailures]",
Review Comment:
If I understand correctly, the command with `-ignoreFailures` always returns
0. If we change it to `-verifyAllFailures`, I think it should return 1 if there
are one or more failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
