tasanuma commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1026391208
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java: ########## @@ -1829,18 +1829,20 @@ public DatanodeCommand[] handleHeartbeat(DatanodeRegistration nodeReg, int totalECBlocks = nodeinfo.getNumberOfBlocksToBeErasureCoded(); int totalBlocks = totalReplicateBlocks + totalECBlocks; if (totalBlocks > 0) { - int maxTransfers; + int maxECTransfers; + int maxReplicationTransfers = blockManager.getMaxReplicationStreams() + - xmitsInProgress;; Review Comment: There are double semicolons. And I prefer that `int maxECTransfers;` is defined just before the if clause. ```suggestion int maxReplicationTransfers = blockManager.getMaxReplicationStreams() - xmitsInProgress; int maxECTransfers; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org