slfan1989 commented on code in PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#discussion_r1027163886
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1941,6 +1963,20 @@ public ByteBuffer readResponse() throws IOException {
public void sendRequest(byte[] buf) throws IOException {
out.write(buf);
}
+
+ public void sendRequest(ProtobufRpcEngine2.RpcProtobufRequestWithHeader
rpcRequest)
+ throws IOException {
+ out.writeInt(rpcRequest.getLength());
+ rpcRequest.getHeader().writeDelimitedTo(out);
+ rpcRequest.getRpcRequest().writeTo(out);
+ }
+
+ public void sendRequest(int totalSize, RpcRequestHeaderProto header,
+ Message rpcRequest) throws IOException {
Review Comment:
5 character indentation is usually required
```
public void sendRequest(int totalSize, RpcRequestHeaderProto header,
Message rpcRequest) throws IOException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
