tasanuma commented on code in PR #5137: URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027248133
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java: ########## @@ -432,8 +432,16 @@ private class VerifyECCommand extends DebugCommand { VerifyECCommand() { super("verifyEC", - "verifyEC -file <file>", - " Verify HDFS erasure coding on all block groups of the file."); + "verifyEC -file <file> [-blockId <blk_Id>] [-ignoreFailures]", Review Comment: @haiyang1987 `-skipFailureBlocks` seems good to me. If we use the words "skip" or "ignore", I don't mind the return value. (I mean, either "always return 0" or "return 0 if there are not any failures, else return 1" would be fine.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org