szilard-nemeth commented on code in PR #4949:
URL: https://github.com/apache/hadoop/pull/4949#discussion_r1028166041
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:
##########
@@ -175,8 +175,12 @@ public enum ExitCode {
COULD_NOT_CREATE_WORK_DIRECTORIES(35),
COULD_NOT_CREATE_APP_LOG_DIRECTORIES(36),
COULD_NOT_CREATE_TMP_DIRECTORIES(37),
- ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38);
-
+ ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38),
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK(80),
+ TOO_LONG_EXECUTOR_PATH(81),
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL(82),
Review Comment:
Replace CANT with CANNOT
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:
##########
@@ -175,8 +175,12 @@ public enum ExitCode {
COULD_NOT_CREATE_WORK_DIRECTORIES(35),
COULD_NOT_CREATE_APP_LOG_DIRECTORIES(36),
COULD_NOT_CREATE_TMP_DIRECTORIES(37),
- ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38);
-
+ ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38),
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK(80),
+ TOO_LONG_EXECUTOR_PATH(81),
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL(82),
+ CANT_GET_EXECUTABLE_NAME_FROM_PID(83),
+ WRONGPATH_OF_EXECUTABLE(84);
Review Comment:
Replace WRONGPATH with WRONG_PATH
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.c:
##########
@@ -337,6 +337,16 @@ const char *get_error_message(const int error_code) {
return "runC run failed";
case ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED:
return "runC reap layer mounts failed";
+ case CANT_GET_EXECUTABLE_NAME_FROM_READLINK:
+ return "Can't get executable name from readlink";
+ case TOO_LONG_EXECUTOR_PATH:
+ return "Too long executor path";
+ case CANT_GET_EXECUTABLE_NAME_FROM_KERNEL:
+ return "Can't get executable name from kernel";
Review Comment:
Replace Can't with Cannot
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.c:
##########
@@ -337,6 +337,16 @@ const char *get_error_message(const int error_code) {
return "runC run failed";
case ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED:
return "runC reap layer mounts failed";
+ case CANT_GET_EXECUTABLE_NAME_FROM_READLINK:
+ return "Can't get executable name from readlink";
+ case TOO_LONG_EXECUTOR_PATH:
+ return "Too long executor path";
+ case CANT_GET_EXECUTABLE_NAME_FROM_KERNEL:
+ return "Can't get executable name from kernel";
+ case CANT_GET_EXECUTABLE_NAME_FROM_PID:
+ return "Can't get executable name from pid";
+ case WRONGPATH_OF_EXECUTABLE:
+ return "Wrongpath of executable";
Review Comment:
Replace "Wrongpath" with "Wrong path"
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.c:
##########
@@ -337,6 +337,16 @@ const char *get_error_message(const int error_code) {
return "runC run failed";
case ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED:
return "runC reap layer mounts failed";
+ case CANT_GET_EXECUTABLE_NAME_FROM_READLINK:
+ return "Can't get executable name from readlink";
+ case TOO_LONG_EXECUTOR_PATH:
+ return "Too long executor path";
+ case CANT_GET_EXECUTABLE_NAME_FROM_KERNEL:
+ return "Can't get executable name from kernel";
+ case CANT_GET_EXECUTABLE_NAME_FROM_PID:
+ return "Can't get executable name from pid";
Review Comment:
Replace Can't with Cannot
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:
##########
@@ -175,8 +175,12 @@ public enum ExitCode {
COULD_NOT_CREATE_WORK_DIRECTORIES(35),
COULD_NOT_CREATE_APP_LOG_DIRECTORIES(36),
COULD_NOT_CREATE_TMP_DIRECTORIES(37),
- ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38);
-
+ ERROR_CREATE_CONTAINER_DIRECTORIES_ARGUMENTS(38),
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK(80),
+ TOO_LONG_EXECUTOR_PATH(81),
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL(82),
+ CANT_GET_EXECUTABLE_NAME_FROM_PID(83),
Review Comment:
Replace CANT with CANNOT
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.h:
##########
@@ -104,7 +104,12 @@ enum errorcodes {
ERROR_RUNC_SETUP_FAILED = 76,
ERROR_RUNC_RUN_FAILED = 77,
ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED = 78,
- ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79
+ ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79,
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK = 80,
+ TOO_LONG_EXECUTOR_PATH = 81,
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL = 82,
+ CANT_GET_EXECUTABLE_NAME_FROM_PID = 83,
+ WRONGPATH_OF_EXECUTABLE = 84
Review Comment:
Replace WRONGPATH with WRONG_PATH
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.h:
##########
@@ -104,7 +104,12 @@ enum errorcodes {
ERROR_RUNC_SETUP_FAILED = 76,
ERROR_RUNC_RUN_FAILED = 77,
ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED = 78,
- ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79
+ ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79,
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK = 80,
+ TOO_LONG_EXECUTOR_PATH = 81,
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL = 82,
+ CANT_GET_EXECUTABLE_NAME_FROM_PID = 83,
Review Comment:
Replace CANT with CANNOT
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.c:
##########
@@ -337,6 +337,16 @@ const char *get_error_message(const int error_code) {
return "runC run failed";
case ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED:
return "runC reap layer mounts failed";
+ case CANT_GET_EXECUTABLE_NAME_FROM_READLINK:
+ return "Can't get executable name from readlink";
Review Comment:
Replace Can't with Cannot
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.h:
##########
@@ -104,7 +104,12 @@ enum errorcodes {
ERROR_RUNC_SETUP_FAILED = 76,
ERROR_RUNC_RUN_FAILED = 77,
ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED = 78,
- ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79
+ ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79,
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK = 80,
Review Comment:
Replace CANT with CANNOT
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.h:
##########
@@ -104,7 +104,12 @@ enum errorcodes {
ERROR_RUNC_SETUP_FAILED = 76,
ERROR_RUNC_RUN_FAILED = 77,
ERROR_RUNC_REAP_LAYER_MOUNTS_FAILED = 78,
- ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79
+ ERROR_DOCKER_CONTAINER_EXEC_FAILED = 79,
+ CANT_GET_EXECUTABLE_NAME_FROM_READLINK = 80,
+ TOO_LONG_EXECUTOR_PATH = 81,
+ CANT_GET_EXECUTABLE_NAME_FROM_KERNEL = 82,
Review Comment:
Replace CANT with CANNOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
