simbadzina commented on code in PR #5142:
URL: https://github.com/apache/hadoop/pull/5142#discussion_r1028474832
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##########
@@ -439,4 +440,60 @@ public void testRouterMsync() throws Exception {
assertEquals("Four calls should be sent to active", 4,
rpcCountForActive);
}
+
+ @Test
+ public void testSingleRead() throws Exception {
+ List<? extends FederationNamenodeContext> namenodes = routerContext
+ .getRouter().getNamenodeResolver()
+ .getNamenodesForNameserviceId(cluster.getNameservices().get(0), true);
+ assertEquals("First namenode should be observer",
namenodes.get(0).getState(),
+ FederationNamenodeServiceState.OBSERVER);
+ Path path = new Path("/");
+
+ long rpcCountForActive;
+ long rpcCountForObserver;
+
+ // Send read request
+ fileSystem.listFiles(path, false);
+ fileSystem.close();
+
+ rpcCountForActive = routerContext.getRouter().getRpcServer()
+ .getRPCMetrics().getActiveProxyOps();
+ // getListingCall sent to active.
+ assertEquals("Only one call should be sent to active", 1,
rpcCountForActive);
+
+ rpcCountForObserver = routerContext.getRouter().getRpcServer()
+ .getRPCMetrics().getObserverProxyOps();
+ // getList call should be sent to observer
+ assertEquals("No calls should be sent to observer", 0,
rpcCountForObserver);
+ }
+
+ @Test
+ public void testSingleReadUsingObserverReadProxyProvider() throws Exception {
+ fileSystem.close();
+ fileSystem = routerContext.getFileSystemWithObserverReadProxyProvider();
Review Comment:
I agree. I'm now moving the code into the individual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
