slfan1989 commented on code in PR #5152: URL: https://github.com/apache/hadoop/pull/5152#discussion_r1033289100
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java: ########## @@ -1,4 +1,4 @@ -/* +/** Review Comment: Thank you for your help reviewing the code! These package-info.java will have this problem in JDK11, we can see the following test report https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5151/8/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt I found that only when there is a new javadoc warning or error, the Java doc error reminder will be triggered. From my personal point of view, we should fix it, so that this module can be completely compiled through JDK11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
