[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640117#comment-17640117 ]
ASF GitHub Bot commented on HADOOP-18543: ----------------------------------------- masteryhx opened a new pull request, #5172: URL: https://github.com/apache/hadoop/pull/5172 <!-- Thanks for sending a pull request! 1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute 2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'. --> ### Description of PR In our application, different components have their own suitable buffer size to download. But currently, AliyunOSSFileSystem#open(Path path, int bufferSize) just get downloadPartSize from configuration. We cannnot use different value for different components in our programs. I think we should the method should use the buffer size from the paramater. AliyunOSSFileSystem#open(Path path) could have default value as current default downloadPartSize. ### How was this patch tested? Added method TestAliyunOSSInputStream#testConfiguration to test. ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use > buffer size as its downloadPartSize > ------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-18543 > URL: https://issues.apache.org/jira/browse/HADOOP-18543 > Project: Hadoop Common > Issue Type: Bug > Components: fs/oss > Reporter: Hangxiang Yu > Priority: Major > > In our application, different components have their own suitable buffer size > to download. > But currently, AliyunOSSFileSystem#open(Path path, int bufferSize) just get > downloadPartSize from configuration. > We cannnot use different value for different components in our programs. > I think we should the method should use the buffer size from the paramater. > AliyunOSSFileSystem#open(Path path) could have default value as current > default downloadPartSize. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org