omalley commented on code in PR #5155:
URL: https://github.com/apache/hadoop/pull/5155#discussion_r1033968329
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -97,6 +106,7 @@
public class RouterAdmin extends Configured implements Tool {
private static final Logger LOG = LoggerFactory.getLogger(RouterAdmin.class);
+ private static final String DUMP_COMMAND = "-dumpState";
Review Comment:
I considered it, but it will make this patch much larger and riskier.
Additionally, it really should be refactored to use the HDFS AdminHelper
utility class. I've filed
[HDFS-16856](https://issues.apache.org/jira/browse/HDFS-16856) to address the
relevant refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
