xkrogen commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1033981920
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ########## @@ -3095,12 +3095,12 @@ LocatedBlock getAdditionalDatanode(String src, long fileId, final byte storagePolicyID; final List<DatanodeStorageInfo> chosen; final BlockType blockType; - checkOperation(OperationCategory.READ); + checkOperation(OperationCategory.WRITE); final FSPermissionChecker pc = getPermissionChecker(); FSPermissionChecker.setOperationType(null); readLock(); try { - checkOperation(OperationCategory.READ); + checkOperation(OperationCategory.WRITE); Review Comment: can we add comments here explaining why we check `WRITE` category even though we only obtain the `READ` lock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org