[ https://issues.apache.org/jira/browse/HADOOP-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641458#comment-17641458 ]
ASF GitHub Bot commented on HADOOP-18526: ----------------------------------------- steveloughran commented on PR #5144: URL: https://github.com/apache/hadoop/pull/5144#issuecomment-1332518475 next pr logs stack at trace ``` 2022-11-30 17:38:32,062 [setup] DEBUG s3a.S3AFileSystem (S3AFileSystem.java:initialize(460)) - Initializing S3AFileSystem for stevel-london 2022-11-30 17:38:32,062 [setup] TRACE s3a.S3AFileSystem (S3AFileSystem.java:initialize(464)) - Filesystem for s3a://stevel-london/ creation stack java.lang.RuntimeException: org.apache.hadoop.fs.s3a.S3AFileSystem@56b21fd5 at org.apache.hadoop.fs.s3a.S3AFileSystem.initialize(S3AFileSystem.java:465) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3595) at org.apache.hadoop.fs.FileSystem.access$300(FileSystem.java:171) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3696) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3647) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:555) at org.apache.hadoop.fs.contract.AbstractBondedFSContract.init(AbstractBondedFSContract.java:72) at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.setup(AbstractFSContractTestBase.java:189) at org.apache.hadoop.fs.s3a.AbstractS3ATestBase.setup(AbstractS3ATestBase.java:111) at org.apache.hadoop.fs.s3a.ITestS3AUnbuffer.setup(ITestS3AUnbuffer.java:61) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:750) ``` > Leak of S3AInstrumentation instances via hadoop Metrics references > ------------------------------------------------------------------ > > Key: HADOOP-18526 > URL: https://issues.apache.org/jira/browse/HADOOP-18526 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.3.4 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > > A heap dump of a process running OOM shows that if a process creates then > destroys lots of S3AFS instances, you seem to run out of heap due to > references to S3AInstrumentation and the IOStatisticsStore kept via the > hadoop metrics registry > It doesn't look like S3AInstrumentation.close() is being invoked in > S3AFS.close(). it should -with the IOStats being snapshotted to a local > reference before this happens. This allows for stats of a closed fs to be > examined. > If you look at org.apache.hadoop.ipc.DecayRpcScheduler.MetricsProxy it uses a > WeakReference to refer back to the larger object. we should do the same for > abfs/s3a bindings. ideally do some template proxy class in hadoop common they > can both use. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org