pranavsaxena-microsoft commented on code in PR #5148:
URL: https://github.com/apache/hadoop/pull/5148#discussion_r1058078015
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/SASGenerator.java:
##########
@@ -85,6 +88,22 @@ private void initializeMac() {
}
}
+ protected String getCanonicalAccountName(String accountName) throws
InvalidConfigurationValueException {
+ // returns the account name without the endpoint
+ int dotIndex = accountName.indexOf(AbfsHttpConstants.DOT);
Review Comment:
You have some string computation over accountname. It would be great if you
could share the semantics of accountname. For example, is it
accountname.dfs.azure.com.
Hope things like containern...@accountname.dfs.azure.com can't happen.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
