surendralilhore commented on PR #5248: URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1370726197
Thanks @liuml07 for review. > 1. Is it possible to figure out some unit tests (not necessarily NN+JN case) for Server and/or UGI? Even the current code change is straightforward, it may be broken by mistake or misunderstanding in future. Adding UT for this scenario is difficult. Passing Sasl message to server without any proper channel and making it fail is difficult. > 2. Do we need `Server#canTryForceLogin` to be thread-safe for multiple connections? Changed `Server#canTryForceLogin` to `AtomicBoolean` > 3. Is it clear to extract the new code in `Server` to a private helper method? Re-login logic extracted in new method and made it synchronized to avoid multiple re-relogin in concurrent scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
