hfutatzhanghb commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063032727
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ########## @@ -97,6 +99,8 @@ private final TreeMap<String, MountTable> tree = new TreeMap<>(); /** Path -> Remote location. */ private final Cache<String, PathLocation> locationCache; + public static LongAdder locCacheMissed = new LongAdder(); + public static LongAdder locCacheAccessed = new LongAdder(); Review Comment: > Thanks @tomscut for reviewing the code. I have updated locCacheMissed to locCacheMiss. But the field locCacheAccessed could not update to locCacheHit. beacuase it mean total cache access count, not cache hit count. Finally, we compute hit rate use : locCacheMiss/locCacheAccess -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
