szetszwo commented on code in PR #5283: URL: https://github.com/apache/hadoop/pull/5283#discussion_r1064004688
########## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ########## @@ -1240,6 +1240,15 @@ </description> </property> +<property> + <name>dfs.namenode.access-control-enforcer-reporting-threshold-ms</name> + <value>1000</value> + <description> + If an external AccessControlEnforcer runs for a long time to check permission with the FSnamesystem lock, + we will print a WARN message when it happens. This sets how long must be run for logging to occur. Review Comment: Change `we will print a WARN message when it happens` to `print a WARN log message`. ########## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ########## @@ -1240,6 +1240,15 @@ </description> </property> +<property> + <name>dfs.namenode.access-control-enforcer-reporting-threshold-ms</name> Review Comment: Please move this right below `dfs.namenode.read-lock-reporting-threshold-ms` since they are related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
