tomscut commented on code in PR #5280: URL: https://github.com/apache/hadoop/pull/5280#discussion_r1064145313
########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java: ########## @@ -662,6 +662,9 @@ public void run() { for (Future<?> f : futureList) { f.get(); } + // Wait for the async deletion task finish. + GenericTestUtils.waitFor(() -> dataset.asyncDiskService.countPendingDeletions() == 0, + 100, 1000); Review Comment: Maybe 1 second is too short. Can we update it to 10 seconds? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org