omalley commented on code in PR #5324:
URL: https://github.com/apache/hadoop/pull/5324#discussion_r1091288711
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -339,8 +341,11 @@ protected NamenodeStatusReport getNamenodeStatusReport() {
// should be required at some point for QoS
updateSafeModeParameters(serviceURI, report);
- // Read the stats from JMX (optional)
- updateJMXParameters(webAddress, report);
+ // Read the stats from JMX (optional) using the login user credentials
+ SecurityUtil.doAsLoginUser((PrivilegedExceptionAction<Void>) () -> {
Review Comment:
It feels like we should do this at a higher level eg.
NamenodeHeartbeatService.periodicInvoke(). That way the other operations, such
as the rpc call to each NN, also run as the login user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
