[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687020#comment-17687020 ]
ASF GitHub Bot commented on HADOOP-18542: ----------------------------------------- CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1425612739 I just reran the whole test suite on a fresh install, and this time everything passed, without changing the code 🤷 Note that I had switched to an HNS account last time already. The unit test you mention was failing on the implementation for the `ClientCredsTokenProvider`, which I hadn't changed (I only changed the logic for `MsiTokenProvider`), and was also failing when running from the upstream trunk branch. There might have been some build cache still using a broken version, it's kind of a mystery to me to be honest. Here is the output showing, feel free to run it yourself: ``` /hadoop/hadoop-tools/hadoop-azure# dev-support/testrun-scripts/runtests.sh [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] Detecting the operating system and CPU architecture [INFO] ------------------------------------------------------------------------ [INFO] os.detected.name: linux [INFO] os.detected.arch: x86_64 [INFO] os.detected.version: 5.15 [INFO] os.detected.version.major: 5 [INFO] os.detected.version.minor: 15 [INFO] os.detected.release: ubuntu [INFO] os.detected.release.version: 22.04 [INFO] os.detected.release.like.ubuntu: true [INFO] os.detected.release.like.debian: true [INFO] os.detected.classifier: linux-x86_64 [INFO] [INFO] -------------------< org.apache.hadoop:hadoop-azure >------------------- [INFO] Building Apache Hadoop Azure support 3.4.0-SNAPSHOT [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] - > Azure Token provider requires tenant and client IDs despite being optional > -------------------------------------------------------------------------- > > Key: HADOOP-18542 > URL: https://issues.apache.org/jira/browse/HADOOP-18542 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure, hadoop-thirdparty > Affects Versions: 3.3.2, 3.3.3, 3.3.4 > Reporter: Carl > Priority: Major > Labels: pull-request-available > > The `AbfsConfiguration` class requires that we provide a tenant and client ID > when using the `MsiTokenProvider` class to fetch an authentication token. The > bug is that those fields are not required by the Azure API, which can infer > those fields when the call is made from an Azure instance. > The fix is to make tenant and client ID optional when getting an Azure token > from the Azure Metadata Service. > A fix has been submitted here: [https://github.com/apache/hadoop/pull/4262] > The bug was introduced with HADOOP-17725 > ([https://github.com/apache/hadoop/pull/3041/files]) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org