ayushtkn commented on code in PR #4215:
URL: https://github.com/apache/hadoop/pull/4215#discussion_r1106063559
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableName.java:
##########
@@ -92,7 +92,7 @@ public static synchronized Class<?> getClass(String name,
Configuration conf
) throws IOException {
Class<?> writableClass = NAME_TO_CLASS.get(name);
if (writableClass != null)
- return writableClass.asSubclass(Writable.class);
+ return writableClass;
Review Comment:
It is a public method and you are changing the behaviour of this. Earlier
for which classes it used to return an Exception.
Now it will be returning some result.
I would suggest add a new method, which can take an argument based on which
it can do .asSubclass(Writable.class) or not, And you can refactor whatever is
inside this method to that new method with an extra flag, and call it from the
existing method with false or so.
Moreover Slack has limited audience, the dev lists have more, so good to
give it a try if none of the options work
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableName.java:
##########
@@ -92,7 +92,7 @@ public static synchronized Class<?> getClass(String name,
Configuration conf
) throws IOException {
Class<?> writableClass = NAME_TO_CLASS.get(name);
if (writableClass != null)
- return writableClass.asSubclass(Writable.class);
+ return writableClass;
Review Comment:
It is a public method and you are changing the behaviour of this. Earlier
for which classes it used to return an Exception.
Now it will be returning some result.
I would suggest add a new method, which can take an argument based on which
it can do .asSubclass(Writable.class) or not, And you can refactor whatever is
inside this method to that new method with an extra flag, and call it from the
existing method with false or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
