steveloughran opened a new pull request, #5412:
URL: https://github.com/apache/hadoop/pull/5412

   
   
   Even though DiskChecker.mkdirsWithExistsCheck() will create the directory 
tree, it is only called *after* the enumeration of directories with available 
space has completed.
   Directories which don't exist are reported as having 0 space, therefore the 
mkdirs code is never reached.
   Adding a simple mkdirs() -without bothering to check the outcome- ensures 
that if a dir has been deleted then it will be reconstructed if possible. If it 
can't it will still have 0 bytes of space reported and so be excluded from the 
allocation.
   
   No need to call exists() first as that is what mkdirs() does first anyway.
   
   
   ### How was this patch tested?
   
   new tests, doing the s3a and abfs runs as diligence
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to