[ https://issues.apache.org/jira/browse/HADOOP-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692006#comment-17692006 ]
ASF GitHub Bot commented on HADOOP-18633: ----------------------------------------- hadoop-yetus commented on PR #5422: URL: https://github.com/apache/hadoop/pull/5422#issuecomment-1439584539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 34s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ branch-3.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 40m 35s | | branch-3.3 passed | | +1 :green_heart: | compile | 0m 30s | | branch-3.3 passed | | +1 :green_heart: | checkstyle | 0m 32s | | branch-3.3 passed | | +1 :green_heart: | mvnsite | 0m 37s | | branch-3.3 passed | | +1 :green_heart: | javadoc | 0m 36s | | branch-3.3 passed | | +1 :green_heart: | spotbugs | 0m 59s | | branch-3.3 passed | | +1 :green_heart: | shadedclient | 26m 57s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 36s | | the patch passed | | +1 :green_heart: | compile | 0m 22s | | the patch passed | | +1 :green_heart: | javac | 0m 22s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 16s | | the patch passed | | +1 :green_heart: | mvnsite | 0m 26s | | the patch passed | | +1 :green_heart: | javadoc | 0m 20s | | the patch passed | | +1 :green_heart: | spotbugs | 0m 51s | | the patch passed | | +1 :green_heart: | shadedclient | 26m 19s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 14m 44s | | hadoop-distcp in the patch passed. | | +1 :green_heart: | asflicense | 0m 37s | | The patch does not generate ASF License warnings. | | | | 117m 25s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5422/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/5422 | | Optional Tests | dupname asflicense mvnsite codespell detsecrets compile javac javadoc mvninstall unit shadedclient spotbugs checkstyle | | uname | Linux 3e6ba6c672a2 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / 6a991f2466bfd4123611eef1c891329b8bebcf49 | | Default Java | Private Build-1.8.0_352-8u352-ga-1~18.04-b08 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5422/1/testReport/ | | Max. process+thread count | 650 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5422/1/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > fix test AbstractContractDistCpTest#testDistCpUpdateCheckFileSkip > ------------------------------------------------------------------ > > Key: HADOOP-18633 > URL: https://issues.apache.org/jira/browse/HADOOP-18633 > Project: Hadoop Common > Issue Type: Bug > Components: tools/distcp > Reporter: Mehakmeet Singh > Assignee: Mehakmeet Singh > Priority: Major > Labels: pull-request-available > > In the newly introduced test testDistCpUpdateCheckFileSkip, for the first > pass of "distcp -update", target file should not be present so that the copy > takes place and creates the target file. > Currently, we create both the source and target file with same block size > from the start which can lead to flakiness due to race condition causing the > modification time of the target file to be greater than/equal to the source > and not copy the file at all. This can be seen more in the > TestLocalContractDistCp due to no remote calls to create the target. > {code:java} > java.lang.AssertionError: Mismatch in COPY counter value expected:<1> but > was:<0> > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.failNotEquals(Assert.java:835) > at org.junit.Assert.assertEquals(Assert.java:647) > at > org.apache.hadoop.tools.contract.AbstractContractDistCpTest.verifySkipAndCopyCounter(AbstractContractDistCpTest.java:1000) > at > org.apache.hadoop.tools.contract.AbstractContractDistCpTest.testDistCpUpdateCheckFileSkip(AbstractContractDistCpTest.java:919) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org