[
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692118#comment-17692118
]
ASF GitHub Bot commented on HADOOP-18565:
-----------------------------------------
ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1114152953
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AProxy.java:
##########
@@ -20,18 +20,17 @@
import java.io.IOException;
-import com.amazonaws.ClientConfiguration;
-import com.amazonaws.Protocol;
import org.assertj.core.api.Assertions;
import org.junit.Test;
+import software.amazon.awssdk.http.apache.ProxyConfiguration;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.s3a.impl.AWSClientConfig;
import org.apache.hadoop.test.AbstractHadoopTestBase;
import static org.apache.hadoop.fs.s3a.Constants.PROXY_HOST;
import static org.apache.hadoop.fs.s3a.Constants.PROXY_PORT;
import static org.apache.hadoop.fs.s3a.Constants.PROXY_SECURED;
-import static org.apache.hadoop.fs.s3a.S3AUtils.initProxySupport;
/**
Review Comment:
@mehakmeet I noticed we introduced a new config option
`fs.s3a.proxy.ssl.enabled`, but the port of the proxy is still set using
`fs.s3a.connection.ssl.enabled`
[here](https://github.com/mehakmeet/hadoop/blob/8d7a7f74e62e4e37a91dc800cfbca698518ec37f/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java#L1323).
Was wondering why need the new `fs.s3a.proxy.ssl.enabled` option? can we not
use `fs.s3a.connection.ssl.enabled` to set the protocol too? Asking here as
this SDK V2 branch uses `fs.s3a.connection.ssl.enabled` to set both protocol +
port, but that causes this test to fail as it uses `fs.s3a.proxy.ssl.enabled`.
> AWS SDK V2 - Complete outstanding items
> ---------------------------------------
>
> Key: HADOOP-18565
> URL: https://issues.apache.org/jira/browse/HADOOP-18565
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Ahmar Suhail
> Priority: Major
> Labels: pull-request-available
>
> The following work remains to complete the SDK upgrade work:
> * S3A allows users configure to custom signers, add in support for this.
> * Remove SDK V1 bundle dependency
> * Update `getRegion()` logic to use retries.
> * Add in progress listeners for `S3ABlockOutputStream`
> * Fix any failing tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
