[
https://issues.apache.org/jira/browse/HADOOP-18606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694847#comment-17694847
]
ASF GitHub Bot commented on HADOOP-18606:
-----------------------------------------
saxenapranav commented on PR #5299:
URL: https://github.com/apache/hadoop/pull/5299#issuecomment-1449328120
Hi @steveloughran,
Thanks for the review. I have made following changes:
1. All enums have got their own class. The implementations are extending an
abstract-class "RetryReasonCategory " which exposes following package-protected
methods. These methods are not public. There is a public method
"captureAndGetAbbreviation" in the abstract class which call these methods.:
1. canCapture: returns if the server-response error can be categorized by
the implementation.
2. getAbbreviation: returns the abbreviation corresponding to the server
response error.
2. RetryReason has a list of implementations of RetryReasonCategory which is
sorted by their significance.
3. Test-class "TestRetryReason" has been added to test each subclass of
RetryReasonCategory implementation.
Requesting you to please review the revision.
Thanks.
> Add reason in in x-ms-client-request-id on a retry API call.
> ------------------------------------------------------------
>
> Key: HADOOP-18606
> URL: https://issues.apache.org/jira/browse/HADOOP-18606
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Reporter: Pranav Saxena
> Assignee: Pranav Saxena
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> In the header, x-ms-client-request-id contains informaiton on what retry this
> particular API call is: for ex:
> :eb06d8f6-5693-461b-b63c-5858fa7655e6:29cb0d19-2b68-4409-bc35-cb7160b90dd8:::CF:1.
> We want to add the reason for the retry in the header_value:Now the same
> header would include retry reason in case its not the 0th iteration of the
> API operation. It would be like
> :eb06d8f6-5693-461b-b63c-5858fa7655e6:29cb0d19-2b68-4409-bc35-cb7160b90dd8:::CF:1_RT.
> This corresponds that its retry number 1. The 0th iteration was failed due
> to read timeout.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
