[GitHub] [hadoop] virajjasani commented on pull request #5445: HDFS-16938. Utility to trigger heartbeat and wait until BP thread queue is fully processed

[via GitHub]

virajjasani commented on PR #5445:
URL: https://github.com/apache/hadoop/pull/5445#issuecomment-1450990755

   I tried multiple cases and for some sleeps, I am able to repro, only 
sometimes.
   
   The only way I am able to consistently repro failure is by applying this 
patch:
   ```
   diff --git 
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
 
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
   index e9f424604b4..c39eca73f38 100755
   --- 
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
   +++ 
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
   @@ -589,6 +589,18 @@ HeartbeatResponse sendHeartBeat(boolean 
requestBlockReportLease)
          scheduler.scheduleNextOutlierReport();
        }
    
   +    try {
   +      Thread.sleep(1000);
   +    } catch (InterruptedException e) {
   +      throw new RuntimeException(e);
   +    }
   +    scheduler.scheduleNextHeartbeat();
   +    try {
   +      Thread.sleep(1000);
   +    } catch (InterruptedException e) {
   +      throw new RuntimeException(e);
   +    }
   +
        return response;
      }
    
   @@ -1012,6 +1024,11 @@ private void processQueueMessages() {
          try {
            LOG.debug("BPServiceActor ( {} ) processing queued messages. Action 
item: {}", this,
                actionItem);
   +        try {
   +          Thread.sleep(1000);
   +        } catch (InterruptedException e) {
   +          throw new RuntimeException(e);
   +        }
            actionItem.reportTo(bpNamenode, bpRegistration);
          } catch (BPServiceActorActionException baae) {
            LOG.warn(baae.getMessage() + nnAddr , baae);
   
   ```
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org