slfan1989 commented on PR #5434: URL: https://github.com/apache/hadoop/pull/5434#issuecomment-1451744187
> checkstyle failing on an unused import; other than that I'm happy -the assertj collection asserts are so much better for asserting on collections and debugging their failures. > > +1 pending the checkstyle fix Thank you very much for your help to review pr! I will continue to use `assertj` to complete the unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org