zhuyaogai commented on code in PR #5391:
URL: https://github.com/apache/hadoop/pull/5391#discussion_r1125837868
##########
hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/OptionsParser.java:
##########
@@ -239,6 +239,21 @@ public static DistCpOptions parse(String[] args)
}
}
+ if (command.hasOption(DistCpOptionSwitch.FAVORED_NODES.getSwitch())) {
+ String favoredNodesStr = getVal(command,
DistCpOptionSwitch.FAVORED_NODES.getSwitch().trim());
+ if (StringUtils.isEmpty(favoredNodesStr)) {
Review Comment:
Add new UT in `TestOptionsParser`, and I think it's ok that YARN cluster can
resolve favored nodes. BTW, it seems that DN does not care about `port` but
`hostname`?
https://github.com/apache/hadoop/blob/2a0dc2ab2f5fb46dc540ed440d6c8b2896dd195b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java#L703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
