steveloughran commented on code in PR #5456:
URL: https://github.com/apache/hadoop/pull/5456#discussion_r1132513808
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericsUtil.java:
##########
@@ -103,14 +113,15 @@ public static boolean isLog4jLogger(Class<?> clazz) {
* @return true if the logger uses Log4J implementation.
*/
public static boolean isLog4jLogger(String logger) {
- if (logger == null) {
+ if (logger == null || !IS_LOG4J_LOGGER.get()) {
return false;
}
Logger log = LoggerFactory.getLogger(logger);
try {
Review Comment:
this try/catch is a duplicate of isLog4jLogger(class).
why not do `isLog4jLogger(LoggerFactory.getLogger(logger))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
