ayushtkn commented on PR #5460: URL: https://github.com/apache/hadoop/pull/5460#issuecomment-1468287415
This wasn't the fix: https://github.com/apache/hadoop/pull/5460#issuecomment-1463012342, rather it broke the javadoc build. Shoot a mvn clean site and find an exception like ``` [ERROR] /hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java:22: error: package org.apache.hadoop.hdfs.server.protocol has already been annotated [ERROR] @InterfaceAudience.Private [ERROR] ^ [ERROR] java.lang.AssertionError [ERROR] at com.sun.tools.javac.util.Assert.error(Assert.java:126) [ERROR] at com.sun.tools.javac.util.Assert.check(Assert.java:45) [ERROR] at com.sun.tools.javac.code.SymbolMetadata.setDeclarationAttributesWithCompletion(SymbolMetadata.java:177) [ERROR] at com.sun.tools.javac.code.Symbol.setDeclarationAttributesWithCompletion(Symbol.java:215) [ERROR] at com.sun.tools.javac.comp.MemberEnter.actualEnterAnnotations(MemberEnter.java:952) [ERROR] at com.sun.tools.javac.comp.MemberEnter.access$600(MemberEnter.java:64) [ERROR] at com.sun.tools.javac.comp.MemberEnter$5.run(MemberEnter.java:876) [ERROR] at com.sun.tools.javac.comp.Annotate.flush(Annotate.java:143) [ERROR] at com.sun.tools.javac.comp.Annotate.enterDone(Annotate.java:129) [ERROR] at com.sun.tools.javac.comp.Enter.complete(Enter.java:512) [ERROR] at com.sun.tools.javac.comp.Enter.main(Enter.java:471) [ERROR] at com.sun.tools.javadoc.JavadocEnter.main(JavadocEnter.java:78) [ERROR] at com.sun.tools.javadoc.JavadocTool.getRootDocImpl(JavadocTool.java:186) ``` Now the original problem That @sodonnel mentioned over here https://github.com/apache/hadoop/pull/5460#issuecomment-1458896438 That the enforcer is giving an exception once he adds package-info.java ``` Duplicate classes: org/apache/hadoop/hdfs/server/protocol/package-info.class ``` And the fix went in the direction this enforcer has gone crazy, lets filter this file itself, but that poor fellow wasn't doing anything wrong :) Check the file-1 https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java Now your added File-2 https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/package-info.java One was already there in hdfs-client, now this got added for the same package on hdfs as well. Why same package on client and hdfs jar, I think all of us here know those reasons, so not getting into that... @sodonnel can you delete this new package-info.java file. And we can fix the build post writing "Checkstyle warnings is irrelevant/unavoidable" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
