[ 
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700891#comment-17700891
 ] 

ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------

virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1470945541

   > it took away some abilities which we could do today and the Deprecated is 
also misunderstood
   
   Ayush, I have added a temporary appender (which will later be removed when 
we move to log4j2 finally) that provides us the same abilities.
   
   I posted on the parent Jira as well HADOOP-16206 :
   
   - Migrating Async appenders from code to log4j properties for namenode audit 
logger as well as datanode/namenode metric loggers
   - Provided sample log4j properties on how we can configure AsyncAppender to 
wrap RFA for the loggers
   - Incompatible change as three hdfs-site configs are no longer in use, they 
are to be replaced with log4j properties. 
   - Deprecated them, added javadoc and log to indicate the log4j replacement 
rather than relying on the configs. The configs: 
      - dfs.namenode.audit.log.async
      - dfs.namenode.audit.log.async.blocking
      - dfs.namenode.audit.log.async.buffer.size
   - namenode audit logger as well as datanode/namenode metric loggers now use 
SLF4J logger rather than log4j logger directly
   




> Migrate Async appenders to log4j properties
> -------------------------------------------
>
>                 Key: HADOOP-18631
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18631
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we 
> add "dynamically in the code" to the log4j.properties file. Instead of using 
> core/hdfs site configs, log4j properties or system properties should be used 
> to determine if the given logger should use async appender.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to