virajjasani commented on PR #5464:
URL: https://github.com/apache/hadoop/pull/5464#issuecomment-1474184981
Agree to the above suggestion of having a new audit logger class and use it
for all operations.
Also Ayush, do you think we should rather have audit logs that indicate the
audit and not the result as such? For instance, here it seems we are trying to
audit the result instead like "whether nameservice was successfully enabled".
Instead, audit log could have been something like "enable nameservice {ns}
is called by client {client/ip etc}". The result of whether or not nameservice
was enabled successfully is something to be saved as internal application logs
only rather than audit, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
