[ https://issues.apache.org/jira/browse/HADOOP-18425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702627#comment-17702627 ]
ASF GitHub Bot commented on HADOOP-18425: ----------------------------------------- steveloughran commented on code in PR #5494: URL: https://github.com/apache/hadoop/pull/5494#discussion_r1141966410 ########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ########## @@ -519,11 +528,26 @@ public AbfsClientRenameResult renamePath( final String destination, final String continuation, final TracingContext tracingContext, - final String sourceEtag, + String sourceEtag, boolean isMetadataIncompleteState) throws AzureBlobFileSystemException { final List<AbfsHttpHeader> requestHeaders = createDefaultHeaders(); + // etag passed in, so source is a file + final boolean hasEtag = isEmpty(sourceEtag); Review Comment: ooh, nice catch. scarily nice. what happens when i code on a weekend > [ABFS]: RenameFilePath Source File Not Found (404) error in retry loop > ---------------------------------------------------------------------- > > Key: HADOOP-18425 > URL: https://issues.apache.org/jira/browse/HADOOP-18425 > Project: Hadoop Common > Issue Type: Bug > Components: fs/azure > Reporter: Sree Bhattacharyya > Assignee: Sree Bhattacharyya > Priority: Minor > Labels: pull-request-available > > RenameFilePath on its first try receives a Request timed out error with code > 500. On retrying the same operation, a Source file not found (404) error is > received. > Possible mitigation: Check whether etags remain the same before and after the > retry and accordingly send an Operation Successful result, instead of source > file not found. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org