[ 
https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703712#comment-17703712
 ] 

ASF GitHub Bot commented on HADOOP-18565:
-----------------------------------------

ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1144985927


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABucketExistence.java:
##########
@@ -124,30 +125,37 @@ private Configuration createConfigurationWithProbe(final 
int probe) {
     Configuration conf = new Configuration(getFileSystem().getConf());
     S3ATestUtils.disableFilesystemCaching(conf);
     conf.setInt(S3A_BUCKET_PROBE, probe);
+    conf.set(AWS_REGION, "eu-west-1");

Review Comment:
   Lmk if you think we should still move to Internal constants, maybe something 
like `DEFAULT_TEST_REGION`, which can be updated as required





> AWS SDK V2 - Complete outstanding items
> ---------------------------------------
>
>                 Key: HADOOP-18565
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18565
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Ahmar Suhail
>            Priority: Major
>              Labels: pull-request-available
>
> The following work remains to complete the SDK upgrade work:
>  * S3A allows users configure to custom signers, add in support for this.
>  * Remove SDK V1 bundle dependency
>  * Update `getRegion()` logic to use retries. 
>  * Add in progress listeners for `S3ABlockOutputStream`
>  * Fix any failing tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to