saxenapranav commented on code in PR #5505: URL: https://github.com/apache/hadoop/pull/5505#discussion_r1146051213
########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java: ########## @@ -3876,10 +3873,8 @@ public boolean hasPathCapability(final Path path, final String capability) throws IOException { // qualify the path to make sure that it refers to the current FS. final Path p = makeQualified(path); - Optional<Boolean> cap = DfsPathCapabilities.hasPathCapability(p, - capability); - if (cap.isPresent()) { - return cap.get(); + if (DfsPathCapabilities.hasPathCapability(p, capability)) { Review Comment: Same comment as given in WebHdfsFileSystem. ########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java: ########## @@ -2207,10 +2206,8 @@ public boolean hasPathCapability(final Path path, final String capability) throws IOException { // qualify the path to make sure that it refers to the current FS. final Path p = makeQualified(path); - Optional<Boolean> cap = DfsPathCapabilities.hasPathCapability(p, - capability); - if (cap.isPresent()) { - return cap.get(); + if (DfsPathCapabilities.hasPathCapability(p, capability)) { Review Comment: what if `validatePathCapabilityArgs(path, capability)` in DfsPathCapablity.hasPathCapablity gives `CommonPathCapabilities.FS_SYMLINKS`. Now, `FileSystem.areSymlinksEnabled()` can be true or false. In earlier code, if `FileSystem.areSymlinksEnabled()` is false, we would retrn from old-line 2213 `cap.get()`. But now, it will go ahead and invoke `super.hasPathCapability(p, capability);` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org