steveloughran commented on code in PR #5521:
URL: https://github.com/apache/hadoop/pull/5521#discussion_r1155685349
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -1196,7 +1196,11 @@ public void abortOutstandingMultipartUploads(long
seconds)
*/
@Override
public String getScheme() {
- return "s3a";
+ if (this.uri != null && this.uri.getScheme() != null){
Review Comment:
just add a field "scheme" with default value FS_S3A; in initialize() set it
to the URI scheme
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/fileContext/ITestS3AFileContext.java:
##########
@@ -13,20 +13,22 @@
*/
package org.apache.hadoop.fs.s3a.fileContext;
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.fs.*;
-import org.junit.Test;
-
-import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
+import org.junit.Test;
import static org.junit.Assert.assertEquals;
Review Comment:
move to bottom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
