[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712374#comment-17712374 ]
ASF GitHub Bot commented on HADOOP-18695: ----------------------------------------- steveloughran commented on code in PR #5548: URL: https://github.com/apache/hadoop/pull/5548#discussion_r1166798332 ########## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AWSRequestAnalyzer.java: ########## @@ -216,6 +216,18 @@ private RequestInfo writing(final String verb, || request instanceof CompleteMultipartUploadRequest || request instanceof GetBucketLocationRequest; } + /** + * Predicate which returns true if the request is part of the + * multipart upload API -and which therefore must be rejected + * if multipart upload is disabled. + * @param request request + * @return true if the transfer manager creates them. + */ + public static boolean isRequestMultipartIO(final Object request) { + return request instanceof CopyPartRequest + || request instanceof CompleteMultipartUploadRequest + || request instanceof InitiateMultipartUploadRequest; + } Review Comment: oh yes. fixed. note that the list/abort uploads is not blocked either; left that alone as they are only used in specific circumstances * s3a committers (which won't work here) * s3guard uploads commmand * if you ask the s3afs to cancel uploads on startup. Which is something we should cut as if it is turned on its dangerous > S3A: reject multipart copy requests when disabled > ------------------------------------------------- > > Key: HADOOP-18695 > URL: https://issues.apache.org/jira/browse/HADOOP-18695 > Project: Hadoop Common > Issue Type: Improvement > Components: fs/s3 > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Labels: pull-request-available > > follow-on to HADOOP-18637 and support for huge file uploads with stores which > don't support MPU. > * prevent use of API against any s3 store when disabled, using logging > auditor to reject it > * tests to verify rename of huge files still works (by setting large part > size) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org