steveloughran commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1508895984
ok, before merging, that spotbugs needs to be quietened ``` ode | Warning -- | -- IS | Inconsistent synchronization of org.apache.hadoop.fs.s3a.S3AFileSystem.s3AsyncClient; locked 50% of time | Bug type IS2_INCONSISTENT_SYNC (click for details)In class org.apache.hadoop.fs.s3a.S3AFileSystemField org.apache.hadoop.fs.s3a.S3AFileSystem.s3AsyncClientSynchronized 50% of the timeUnsynchronized access at S3AFileSystem.java:[line 1675]Unsynchronized access at S3AFileSystem.java:[line 994]Synchronized access at S3AFileSystem.java:[line 4051]Synchronized access at S3AFileSystem.java:[line 4056] ode Warning IS Inconsistent synchronization of org.apache.hadoop.fs.s3a.S3AFileSystem.s3AsyncClient; locked 50% of time [Bug type IS2_INCONSISTENT_SYNC (click for details)](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5421/14/artifact/out/branch-spotbugs-hadoop-tools_hadoop-aws-warnings.html#IS2_INCONSISTENT_SYNC) In class org.apache.hadoop.fs.s3a.S3AFileSystem Field org.apache.hadoop.fs.s3a.S3AFileSystem.s3AsyncClient Synchronized 50% of the time Unsynchronized access at S3AFileSystem.java:[line 1675] Unsynchronized access at S3AFileSystem.java:[line 994] Synchronized access at S3AFileSystem.java:[line 4051] Synchronized access at S3AFileSystem.java:[line 4056] ``` if it is a false alarm, add an exclusion in `hadoop-tools/hadoop-aws/dev-support/findbugs-exclude.xml` do see if there is a real risk first, before just disabling though. Assuming it is created in the unsynchronized initialize() method, if access, even internally, is through an unsync getter all should be good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
