[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712470#comment-17712470 ]
ASF GitHub Bot commented on HADOOP-18691: ----------------------------------------- smengcl commented on code in PR #5540: URL: https://github.com/apache/hadoop/pull/5540#discussion_r1167086957 ########## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIdentityProviders.java: ########## @@ -51,6 +54,9 @@ public int getPriorityLevel() { } } + @Rule + public ExpectedException exception = ExpectedException.none(); Review Comment: Looks like CI is not happy with the usage of `ExpectedException` here > Add a CallerContext getter on the Schedulable interface > ------------------------------------------------------- > > Key: HADOOP-18691 > URL: https://issues.apache.org/jira/browse/HADOOP-18691 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Christos Bisias > Priority: Major > Labels: pull-request-available > > We would like to add a default *{color:#00875a}CallerContext{color}* getter > on the *{color:#00875a}Schedulable{color}* interface > {code:java} > default public CallerContext getCallerContext() { > return null; > } {code} > and then override it on the > *{color:#00875a}i{color}{color:#00875a}{*}pc/{*}Server.Call{color}* class > {code:java} > @Override > public CallerContext getCallerContext() { > return this.callerContext; > } {code} > to expose the already existing *{color:#00875a}callerContext{color}* field. > > This change will help us access the *{color:#00875a}CallerContext{color}* on > an Apache Ozone *{color:#00875a}IdentityProvider{color}* implementation. > On Ozone side the *{color:#00875a}FairCallQueue{color}* doesn't work with the > Ozone S3G, because all users are masked under a special S3G user and there is > no impersonation. Therefore, the FCQ reads only 1 user and becomes > ineffective. We can use the *{color:#00875a}CallerContext{color}* field to > store the current user and access it on the Ozone > {*}{color:#00875a}IdentityProvider{color}{*}. > > This is a presentation with the proposed approach. > [https://docs.google.com/presentation/d/1iChpCz_qf-LXiPyvotpOGiZ31yEUyxAdU4RhWMKo0c0/edit#slide=id.p] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org