szetszwo commented on PR #5532: URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1511669706
> Are we planning to address here? [#5532 (comment)](https://github.com/apache/hadoop/pull/5532#issuecomment-1499923239) Probably not. I found a potential fix shown below -- it should update `snapshotId` only if it is larger. It might be able to fix the bug. However, it is a very big change since it change the rename diff entries and completely change the rename-cleanup-algorithm. ```java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodesInPath.java @@ -181,7 +181,9 @@ static INodesInPath resolve(final INodeDirectory startingDir, (sf = curNode.asDirectory().getDirectoryWithSnapshotFeature()) != null) { lastSnapshot = sf.getLastSnapshotId(); } - snapshotId = lastSnapshot; + if (lastSnapshot > snapshotId) { + snapshotId = lastSnapshot; + } } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
