goiri commented on code in PR #5551:
URL: https://github.com/apache/hadoop/pull/5551#discussion_r1171879611


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/CheckForDecommissioningNodesRequest.java:
##########
@@ -32,4 +34,31 @@ public static CheckForDecommissioningNodesRequest 
newInstance() {
         .newRecord(CheckForDecommissioningNodesRequest.class);
     return request;
   }
+
+  @Private
+  @Unstable
+  public static CheckForDecommissioningNodesRequest newInstance(String 
subClusterId) {
+    CheckForDecommissioningNodesRequest request = Records
+        .newRecord(CheckForDecommissioningNodesRequest.class);
+    request.setSubClusterId(subClusterId);
+    return request;
+  }
+
+  /**
+   * Get the subClusterId.
+   *
+   * @return subClusterId.
+   */
+  @InterfaceAudience.Public

Review Comment:
   Let's be consistent, either just Public or the whole thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to