adoroszlai opened a new pull request, #5578: URL: https://github.com/apache/hadoop/pull/5578
## What changes were proposed in this pull request? Fix assertion message in `AbstractContractRootDirectoryTest` by calling `join(Object[], String)` instead of `join(T...)` (where `T` was calculated to be `Serializable`). Steps to reproduce: 1. Make `AbstractContractRootDirectoryTest` fail by commenting out the `assertDeleted` call inside the loop: https://github.com/apache/hadoop/blob/964c1902c8054dfe13c787222a12fb0daf1aaab9/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRootDirectoryTest.java#L194-L201 2. Run `TestHDFSContractRootDirectory`: ``` $ mvn -DfailIfNoTests=false -am -pl :hadoop-hdfs -Dtest=TestHDFSContractRootDirectory clean test ... [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.708 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory [ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory) Time elapsed: 0.011 s <<< FAILURE! java.lang.AssertionError: listStatus on empty root-directory returned found: [Lorg.apache.hadoop.fs.FileStatus;@73344c46 expected:<0> but was:<1> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199) ``` https://issues.apache.org/jira/browse/HADOOP-18714 ## How was this patch tested? ``` $ mvn -DfailIfNoTests=false -am -pl :hadoop-hdfs -Dtest=TestHDFSContractRootDirectory clean test ... ``` [ERROR] Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.711 s <<< FAILURE! - in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory [ERROR] testListEmptyRootDirectory(org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRootDirectory) Time elapsed: 0.011 s <<< FAILURE! java.lang.AssertionError: listStatus on empty root-directory returned found: HdfsLocatedFileStatus{path=hdfs://localhost:37225/test; isDirectory=true; ...} expected:<0> but was:<1> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.apache.hadoop.fs.contract.AbstractContractRootDirectoryTest.testListEmptyRootDirectory(AbstractContractRootDirectoryTest.java:199) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
