simbadzina commented on code in PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#discussion_r1174047769
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -132,15 +135,15 @@ public void printUsage() {
System.out.println(usage);
}
- private void printUsage(String cmd) {
+ private static void printUsage(String cmd) {
String usage = getUsage(cmd);
System.out.println(usage);
}
- private String getUsage(String cmd) {
+ private static String getUsage(String cmd) {
if (cmd == null) {
String[] commands =
- {"-add", "-update", "-rm", "-ls", "-getDestination", "-setQuota",
+ {"-add", "-addall", "-update", "-rm", "-ls", "-getDestination",
"-setQuota",
Review Comment:
Can we use a static String. The way `DUMP_COMMAND` was added in
https://github.com/apache/hadoop/pull/5155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
