simbadzina commented on code in PR #5572:
URL: https://github.com/apache/hadoop/pull/5572#discussion_r1174123604


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##########
@@ -2230,6 +2230,25 @@ public void testLinkTarget() throws Exception {
     }
   }
 
+  @Test
+  public void testFileLinkStatus() throws Exception {
+    final Configuration conf = WebHdfsTestUtil.createConf();
+    cluster = new MiniDFSCluster.Builder(conf).numDataNodes(3).build();
+    cluster.waitActive();
+
+    final WebHdfsFileSystem webHdfs = 
WebHdfsTestUtil.getWebHdfsFileSystem(conf,
+        WebHdfsConstants.WEBHDFS_SCHEME);
+    // Symbolic link
+    Path root = new Path("/webHdfsTest/");
+    Path file = new Path(root, "file");
+    FileSystemTestHelper.createFile(webHdfs, file);
+
+    Path linkToFile = new Path(root, "linkToFile");
+
+    webHdfs.createSymlink(file, linkToFile, false);
+    assertTrue(webHdfs.getFileLinkStatus(linkToFile).isSymlink());
+  }

Review Comment:
   Can you also test that the correct result is returned when the path is not a 
symLink.



##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:
##########
@@ -2160,6 +2161,26 @@ Path decodeResponse(Map<?, ?> json) {
     }.run();
   }
 
+  @Override
+  public FileStatus getFileLinkStatus(Path f)
+      throws AccessControlException, FileNotFoundException,
+      UnsupportedFileSystemException, IOException {

Review Comment:
   We only need the IOException here, since it is a parent of the others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to