[ 
https://issues.apache.org/jira/browse/HADOOP-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221334#comment-13221334
 ] 

Todd Lipcon commented on HADOOP-8135:
-------------------------------------

{code}
+   * @return - the number of bytes available to read from buf
{code}
style nit: no '-' here

- maybe worth noting in the javadoc that many FS implementations may throw 
UnsupportedOperationException, and add that to the javadoc as well
                
> Add ByteBufferReadable interface to FSDataInputStream
> -----------------------------------------------------
>
>                 Key: HADOOP-8135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8135
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>         Attachments: HADOOP-8135.patch
>
>
> To prepare for HDFS-2834, it's useful to add an interface to 
> FSDataInputStream (and others inside hdfs) that adds a read(ByteBuffer...) 
> method as follows:
> {code}
>   /**
>    * Reads up to buf.remaining() bytes into buf. Callers should use
>    * buf.limit(..) to control the size of the desired read.
>    * 
>    * After the call, buf.position() should be unchanged, and therefore any 
> data
>    * can be immediately read from buf.
>    * 
>    * @param buf
>    * @return - the number of bytes available to read from buf
>    * @throws IOException
>    */
>   public int read(ByteBuffer buf) throws IOException;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to